Repository navigation
MAINT: remove broken parallel cparser - #16103
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
taldcroft
requested changes
Feb 25, 2024
taldcroft
left a comment
taldcroft
left a comment
Member
There was a problem hiding this comment.
We'll need to rely on tests to be sure this is OK, but it basically looks good. It looks like there are a few remaining parallel references:
➜ ascii git:(pr/MridulS/16103) pwd
/Users/aldcroft/git/astropy/astropy/io/ascii
➜ ascii git:(pr/MridulS/16103) find . -type f | xargs grep -i parallel
./tests/test_c_reader.py: # test_for_warnings = fast_reader and not parallel
./tests/test_c_reader.py: # if not parallel and not fast_reader:
➜ ascii git:(pr/MridulS/16103) cd ~/git/astropy/docs/io/ascii
➜ ascii git:(pr/MridulS/16103) find . -type f | xargs grep -i parallel
./fast_ascii_io.rst:Parallel and Fast Conversion Options
./fast_ascii_io.rst: Parallel and Fast Conversion Options for Faster Table Reading
This also needs an API change log entry.
taldcroft
added
the
API change
MridulS
force-pushed
the
remove_parallel
branch
from
February 26, 2024 07:54
6353640 to
ce7d3f2
Compare
Member
|
Unfortunately a Wheel building CI failed which is presumably unrelated. Since CI needs to run again, there is one tiny thing I'd like to fix. |
taldcroft
reviewed
Feb 26, 2024
Co-authored-by: Tom Aldcroft <[email protected]>
pllim
reviewed
Feb 26, 2024
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10882, this removes
parallelkeyword from the cparser. As this has been broken for a long time and the code has been raising warning for some time now so I guess we probably don't need to go through the deprecation cycle.