Repository navigation
BUG: make report_diff_values returns consistent (ignoring terminal size) - #16065
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
force-pushed
the
utils/diff/diff_large_tables
branch
from
February 19, 2024 10:28
89f1646 to
3456e6e
Compare
pllim
reviewed
Feb 19, 2024
taldcroft
requested changes
Feb 20, 2024
taldcroft
left a comment
taldcroft
left a comment
Member
There was a problem hiding this comment.
Looks good, just a few nits.
| colnames.insert(50, "test") | ||
| t2 = Table(names=colnames) | ||
|
|
||
| assert not report_diff_values(t1, t2) |
Member
There was a problem hiding this comment.
Just to be tidy I'd suggest catching the output in a StringIO() object like above. It feels not nice to be printing some huge diff to stdout in the test.
| @@ -0,0 +1 @@ | |||
| Make ``report_diff_values`` returns consistent (ignoring terminal size). | |||
Member
There was a problem hiding this comment.
Suggested change
| Make ``report_diff_values`` returns consistent (ignoring terminal size). | |
| Update ``report_diff_values`` so the diff no longer depends on the console terminal size. |
neutrinoceros
force-pushed
the
utils/diff/diff_large_tables
branch
from
February 20, 2024 15:36
3456e6e to
7eac388
Compare
Contributor
Author
|
@taldcroft thanks for your review ! I've addressed your comments. |
Member
|
@pllim - you marked this a 6.1.0. I think this version should be backport-able since it is pretty narrow and fixes a problem that is clearly a bug IMO. |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Feb 20, 2024
…stent (ignoring terminal size)
Member
|
OK it will be backported. Thanks, all! |
pllim
added a commit
that referenced
this pull request
Feb 20, 2024
…065-on-v6.0.x Backport PR #16065 on branch v6.0.x (BUG: make report_diff_values returns consistent (ignoring terminal size))
d-giles
referenced
this pull request
in d-giles/astropy-abdufork
Jul 26, 2024
…ze) (#16065) * TST: add a regression test for issue 14010 * BUG: make report_diff_values returns consistent (ignoring terminal size)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14010 in a backportable fashion as suggested by @taldcroft. This puts the context manager in a decorator to minimize the diff.
Broader changes are to be discussed in #15828 and should probably be defered to the next major version.