DEPR: deprecate astropy.utils.console.terminal_size and stop using it internally - #16045

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

failures are real. Let me check if I can fix that easily.

I fixed the worst ones but there are still a lot and I'm not sure they're actually fixable. Maybe the solution is simply not to deprecate this function.

whoops, I missed that get_terminal_size gave (columns, lines), and terminal_size does the reversed. Should be good now ? 🤞🏻

2 remaining failures in Table.pprint tests, that I think are due to slight differences in what the replacement function returns. Without looking too deeply into it, I would assume the function from the standard lib is more reliable so the change could be considered a bug fix. Otherwise it's likely possible to force bug-for-bug compatibility.

I think it is OK to adjust the doctests. To be honest, showing 1 line before the ... and 2 after seems better than 1 and 3 (2 and 2 would perhaps be more logical, but, really, no big deal...

#16040 is merged. Please rebase. Thanks!

rebased !

whoops, I missed that get_terminal_size gave (columns, lines), and terminal_size does the reversed. Should be good now ?

Also they disagree by 1:

In [3]: shutil.get_terminal_size()
Out[3]: os.terminal_size(columns=96, lines=46)

In [4]: from astropy.utils import console

In [5]: console.terminal_size()
Out[5]: (40, 95)

It seems shutil.get_terminal_size is right, here I can print 96 characters on one line.

yes this is what I hinted to in #16045 (comment) (I could have been more explicit). I think this is also why some doctests adjustments are required.
Actually one of them is still failing, let me switch to draft until I get it back to green.

ready at last !

@mhvk - just curious why you labeled this as a bug?

Oops, my mistake - I saw a fixes ... and assumed there was also a bug involved. Now removed.

@pllim - I think this one is ready (it was rebased following your request); could you check? (And go ahead and merge if it is all OK!)