Repository navigation
BUG: fix extraneous space in LaTeX repr for Quantity objects with superscript units - #16043
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
neutrinoceros
force-pushed
the
units/bug/deg_to_latex
branch
from
February 14, 2024 17:44
5fb3c45 to
bcf7284
Compare
neutrinoceros
marked this pull request as ready for review
February 14, 2024 17:46
mhvk
reviewed
Feb 14, 2024
| delimiter_left, delimiter_right = formats[format][subfmt] | ||
|
|
||
| return rf"{delimiter_left}{latex_value} \; {latex_unit}{delimiter_right}" | ||
| if self.unit == Unit("deg"): |
Contributor
There was a problem hiding this comment.
Hmm, we probably then also should do "arcmin", "arcsec", and "hourangle"
And this is of course not the first time we are dealing with this - as you note, you don't want to do it for composite units, or if the unit is raised to some power....
How about the following hack?
# Add a space in front except for super-script units like degrees.
if not latex_unit.startswith("{}^") or unit is u.deg_C:
latex_unit = r"\;" + latex_unit
and then remove the \; below.
Contributor
Author
There was a problem hiding this comment.
of course ! sorry for not thinking of other angular units. I've extended the test and refactored the code based on your suggestion
neutrinoceros
force-pushed
the
units/bug/deg_to_latex
branch
2 times, most recently
from
February 15, 2024 08:23
fe73492 to
3e436d2
Compare
neutrinoceros
force-pushed
the
units/bug/deg_to_latex
branch
from
February 15, 2024 08:24
3e436d2 to
aebba02
Compare
neutrinoceros
changed the title
mhvk
approved these changes
Feb 18, 2024
mhvk
left a comment
mhvk
left a comment
Contributor
There was a problem hiding this comment.
Sorry, had lost track of this one - now looks all good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14385
Special casing seems simple enough here. Maybe the check should be more fine tuned so that composite units that have
degas their first element also follow this special path ? I just assumed this wasn't desired.