Skip to content

Enable Ruff allow-dict-calls-with-keyword-arguments setting - #15915

Merged
mhvk merged 1 commit into
astropy:mainfrom
eerovaher:allow-keyword-dicts
Jan 19, 2024
Merged

mhvk merged 1 commit into
astropy:mainfrom
eerovaher:allow-keyword-dicts

Conversation

@eerovaher

Copy link
Copy Markdown
Member

Description

allow-dict-calls-with-keyword-arguments configures Ruff rule C408 to allow dict calls with keyword arguments (e.g. dict(a=1, b=2)). Ruff will still replace dict() with {}. C408 can now be enabled in several sub-packages.

This is in response to #15664 (comment)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

The new setting configures Ruff rule C408 (unnecessary-collection-call)
to allow `dict` calls with keyword arguments (e.g. `dict(a=1, b=2)`).
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@eerovaher eerovaher mentioned this pull request Jan 19, 2024
1 task

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eerovaher

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nice solution!

@mhvk

mhvk commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

I'll get this in - it allows #15664 to move forward and we can always re-evaluate.

@mhvk

mhvk commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

p.s. Thanks @eerovaher!

@mhvk
mhvk merged commit 7b2fe0f into astropy:main Jan 19, 2024
@eerovaher
eerovaher deleted the allow-keyword-dicts branch January 19, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants