Skip to content

Allow the spectral_density equivalency to take a Quantity #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
astrofrog wants to merge 1 commit into from
Closed

Allow the spectral_density equivalency to take a Quantity #1590

astrofrog wants to merge 1 commit into from

Conversation

@astrofrog
Copy link
Member

@astrofrog astrofrog commented Oct 16, 2013

@mdboom - what do you think? I had to use the current API today and it felt clunky (also, other equivalencies now take quantities). Should we actually deprecate the previous API?

@mdboom
Copy link
Contributor

mdboom commented Oct 16, 2013

Yeah -- the original API predates Quantity.

I think #1560 already does this (as part of some larger changes).

@astrofrog
Copy link
Member Author

astrofrog commented Oct 16, 2013

Ah yes, then I'll leave this open for now but it can be closed without merging once #1560 is merged.

@eteq
Copy link
Member

eteq commented Oct 16, 2013

FYI, I think this will be much less important when we have a Flux object (#1577 , although I'm not sure if it actually implements this feature), as you never have to bother with the actual equivalency if you use that. This was actually the main use case in my head for being able to store equivalencies in quantities.

@pllim
Copy link
Member

pllim commented Oct 17, 2013

Ops... sorry for the duplicate work. I like the backward compatibility option here, which is not in my PR.

@astrofrog
Copy link
Member Author

astrofrog commented Oct 17, 2013

@pllim - feel free to implement that in your PR and we can just close this one once yours is merged :)

pllim added a commit to pllim/astropy that referenced this pull request Oct 17, 2013
@pllim
Added text to CHANGES.rst as suggested by @eteq. Applied changes from a…
b3dfdeb 
…stropy#1590 to this PR, as suggested by @astrofrog.
@pllim pllim mentioned this pull request Oct 17, 2013
Closed
eteq pushed a commit to eteq/astropy that referenced this pull request Oct 17, 2013
@pllim @eteq
Added text to CHANGES.rst as suggested by @eteq. Applied changes from a…
935350e 
…stropy#1590 to this PR, as suggested by @astrofrog.
@pllim
Copy link
Member

pllim commented Oct 18, 2013

@eteq -- This should be closed too. It was implemented in #1560 that you just merged. FYI.

@eteq
Copy link
Member

eteq commented Oct 18, 2013

Good call, thanks @pllim

@eteq eteq closed this Oct 18, 2013
@astrofrog astrofrog deleted the spectral-density-argument branch July 5, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@astrofrog @mdboom @eteq @pllim