Skip to content

Conversation

@mwcraig
Copy link
Member

@mwcraig mwcraig commented Oct 15, 2013

This pull request addresses issue #1567

@embray
Copy link
Member

embray commented Oct 15, 2013

Thanks, I think that's fine--indeed the example is not correct. It might be worth keeping if the example were just changed to not try to use .set() the way it's doing. But I don't think we really need to encourage that usage anyways, especially given that it might change when we redo configuration....

@eteq
Copy link
Member

eteq commented Oct 18, 2013

This is actually a pretty serious bug in config. But I agree with @embray that this is an illustration of why we want to revamp config anyway (lots of configobj weirdness), so I'm fine with just merging it given it'll all change in the next version anyway.

eteq added a commit that referenced this pull request Oct 18, 2013
…ssue-1567

Remove incorrect description of setting a configuration value at runtime
@eteq eteq merged commit af1a83d into astropy:master Oct 18, 2013
@eteq
Copy link
Member

eteq commented Oct 18, 2013

@mwcraig - A quick tip: if you include the text closes #1567 in one of the commit messages (usually I do this on the second line so that it doesn't clutter the single-line commit log), it will automatically close the issue when this is merged. Helps with the bookeeping just a bit.

@mwcraig mwcraig deleted the fix-runtime-configuration-doc-issue-1567 branch December 8, 2013 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants