Skip to content

MAINT: Remove deprecated keywords args from io.ascii - #15758

Merged
taldcroft merged 3 commits into
astropy:mainfrom
MridulS:gh-15536
May 10, 2024
Merged

taldcroft merged 3 commits into
astropy:mainfrom
MridulS:gh-15536

Conversation

@MridulS

@MridulS MridulS commented Dec 17, 2023 •

Copy link
Copy Markdown
Contributor

This removes the deprecated keywords args in #14914

Closes #15536

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v7.0.0 milestone Dec 18, 2023
@pllim pllim added API change PRs and issues that change an existing API, possibly requiring a deprecation period and removed visualization labels Dec 18, 2023
@taldcroft

Copy link
Copy Markdown
Member

Yay! I'm not sure how we remember this for the 7.0.0 release.

@pllim

pllim commented Dec 19, 2023

Copy link
Copy Markdown
Member

This PR is milestoned to 7.0, so after main is slated for v7.0.dev , we can revisit all such PRs with GitHub search for this milestone.

@pllim

pllim commented Dec 19, 2023

Copy link
Copy Markdown
Member

If authors no longer involved in the project by then, maintainers will have to take over, as usual.

@taldcroft

Copy link
Copy Markdown
Member

I suppose when the time comes we might want to rebase on main to be sure.

@pllim

pllim commented Dec 19, 2023

Copy link
Copy Markdown
Member

might want to rebase

Yes, I agree 100%!

@eerovaher

Copy link
Copy Markdown
Member

There is now a separate branch for astropy 6.1, so this pull request can be finalized.

@pllim

pllim commented May 9, 2024

Copy link
Copy Markdown
Member

@MridulS no longer has contract with us, so a maintainer might have to take over.

@taldcroft
taldcroft marked this pull request as ready for review May 10, 2024 10:40

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taldcroft
taldcroft enabled auto-merge (squash) May 10, 2024 13:46
@taldcroft
taldcroft merged commit 7f55d85 into astropy:main May 10, 2024
d-giles referenced this pull request in d-giles/astropy-abdufork Jul 26, 2024
* Remove deprecated keywords args from io.ascii

* add api changelog

* Additional cleanup for removing deprecated args

---------

Co-authored-by: Tom Aldcroft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period io.ascii

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove io.ascii keyword arguments that were deprecated in v6.0

4 participants