Minor cleanup in coordinates sub-package
#1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this @cdeil, but it looks like this collided with one of the many coordinates changes currently under PR. Feel free to rebase, but it might be easier to wait on this until we're not going to do any significant changes prior to v0.3 (and there are still a few under discussion). Then you can rebase this right before release instead of having to do so multiple times. |
eteq
added a commit
that referenced
this pull request
Oct 18, 2013
Member
|
@cdeil - I merged this manually resolving the conflicts now that the other pending PRs are in for coordinates. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some very minor cleanup in
coordinatesthat my editor points out, e.g. noimport *.@eteq Can the
angle_axisfunction inangles.pybe removed or should it be fixed and added to__all__? (It usesfrom numpy import acoswhich doesn't exist (it's calledarccos), so must be unused.)