Integer quantity times list should not be treated as repitition count #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This might not be something we can do anything about, but it's good to know the problem exists. |
Member
|
That's bizarre. I had always assumed that the iterable times integer operation in Python was non-commutative. But clearly I was wrong in that assumption. |
Contributor
Author
|
@astrofrog, @embray - found the culprit: we needed to define |
Member
|
@mhvk - thanks for identifying this! It would be nice to include the original issue you reported here as a regression test. |
Contributor
Author
|
@astrofrog - OK, better test added. |
Contributor
|
👍 |
astrofrog
added a commit
that referenced
this pull request
Oct 14, 2013
Integer quantity times list should not be treated as repitition count
Member
|
Wow--a Python feature I did not know existed. Looks like it was added specifically for Numpy... |
mhvk
added a commit
to mhvk/astropy
that referenced
this pull request
Oct 15, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following weird behaviour:
yields
So, the integer in the
Quantityis taken as a repeat counter. Apparently, afterQuantityappropriately fails to produce a multiplication, the list's__rmul__manages to access the array without checking the unit --- certainlyint(u.Quantity(2, 'm')fails appropriately.