Skip to content

MNT: Stop updating IERS in v5.0.x and v5.3.x - #15568

Merged
saimn merged 1 commit into
astropy:mainfrom
pllim:byebye-iers-for-old-branches
Nov 2, 2023
Merged

MNT: Stop updating IERS in v5.0.x and v5.3.x#15568
saimn merged 1 commit into
astropy:mainfrom
pllim:byebye-iers-for-old-branches

Conversation

@pllim

@pllim pllim commented Nov 1, 2023

Copy link
Copy Markdown
Member

Description

This pull request is to remove the script to auto-update IERS tables in v5.0.x and v5.3.x because both of these branches will be at EOL when 6.0 is released.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v6.1 milestone Nov 1, 2023
@pllim
pllim requested a review from a team November 1, 2023 15:29
@github-actions

github-actions Bot commented Nov 1, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

saimn
saimn approved these changes Nov 2, 2023
View reviewed changes

@saimn saimn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks.

@saimn
saimn merged commit 115362b into astropy:main Nov 2, 2023
@pllim
pllim deleted the byebye-iers-for-old-branches branch November 2, 2023 21:06
@neutrinoceros neutrinoceros mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saimn saimn saimn approved these changes

Assignees

No one assigned

Labels

dev-automation no-changelog-entry-needed testing

Projects

None yet

Milestone

v6.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @saimn