Define dimensionless_unscaled differently so it can be imported more easily #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 I think this means we can also removed the definition of |
Contributor
Author
|
@mdboom - Thanks! Had actually made that change but had forgotten to add it. |
Member
|
👍 |
astrofrog
added a commit
that referenced
this pull request
Oct 12, 2013
Define dimensionless_unscaled differently so it can be imported more easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An annoyance in
Quantityhas been that one cannot importdimensionless_unscaledon top, since it needs the registry to be set up. By defining it instead asCompositeUnit(1, [], [])(as is done when one doesUnit('')), this is avoided. Hence, all the local imports inquantity.pyandquantity_helpers.pycould be removed.Note that I need this for an upcoming PR for
MaskedQuantity-- which in turn should help make Table/Quantity integration easier.