Skip to content

Regression test for non-contiguous transformation matrices - #15511

Merged
mhvk merged 1 commit into
astropy:mainfrom
mhvk:representation-transform-with-non-contiguous-matrix
Oct 19, 2023
Merged

Regression test for non-contiguous transformation matrices#15511
mhvk merged 1 commit into
astropy:mainfrom
mhvk:representation-transform-with-non-contiguous-matrix

Conversation

@mhvk

@mhvk mhvk commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

This PR doesn't fix anything -- the fix is liberfa/pyerfa#124 -- but it adds a regression test, since really we should have tested earlier that using a non-contiguous matrix in repr.transform() worked.

Does not need a changelog or backport, since the fix itself relies on using latest pyerfa -- which should be in by now (i.e., all tests should pass, which isn't the case with pyerfa 2.0.1)

Fixes #15503

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added this to the v6.0 milestone Oct 19, 2023
@mhvk
mhvk requested a review from pllim October 19, 2023 18:50
@github-actions

github-actions Bot commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk mentioned this pull request Oct 19, 2023
Closed
pllim
pllim approved these changes Oct 19, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra test never hurts but @ayshih confirmation that this test looks good would be nice (but not required). Thanks!

@mhvk
mhvk force-pushed the representation-transform-with-non-contiguous-matrix branch from 39b6093 to 6bbc5c7 Compare October 19, 2023 21:07
@mhvk
mhvk enabled auto-merge October 19, 2023 21:09
@ayshih

ayshih commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

@ayshih confirmation that this test looks good would be nice

👍

@mhvk
mhvk force-pushed the representation-transform-with-non-contiguous-matrix branch from 6bbc5c7 to f3bd3b5 Compare October 19, 2023 22:09
@mhvk
mhvk merged commit c723da8 into astropy:main Oct 19, 2023
@mhvk
mhvk deleted the representation-transform-with-non-contiguous-matrix branch October 20, 2023 00:40
@eerovaher eerovaher mentioned this pull request Dec 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eerovaher eerovaher eerovaher left review comments
@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

coordinates no-changelog-entry-needed testing

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

Transforming a CartesianRepresentation gives the wrong answer for a non-contiguous float matrix

4 participants

@mhvk @ayshih @pllim @eerovaher