Skip to content

Decompress FITS files in memory - #15501

Merged
astrofrog merged 5 commits into
astropy:mainfrom
saimn:fits-decompress-in-memory
Oct 19, 2023
Merged

astrofrog merged 5 commits into
astropy:mainfrom
saimn:fits-decompress-in-memory

Conversation

@saimn

@saimn saimn commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Fix #14855

Description

This pull request is to address ...

Fixes #

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added the io.fits label Oct 17, 2023
@saimn saimn added this to the v6.0 milestone Oct 17, 2023
@saimn
saimn requested a review from astrofrog October 17, 2023 21:08
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@astrofrog astrofrog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and this will be very useful! Just a couple of small comments below on terminology but approving since not critical if you don't have time.

Comment thread astropy/io/fits/hdu/hdulist.py Resolved
Comment thread docs/changes/io.fits/15501.feature.rst Resolved
@astrofrog

Copy link
Copy Markdown
Member

Actually could you add a 'What's New' entry for this?

@saimn

saimn commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

@astrofrog - I was thinking "FITS blocks" but I agree it's not so clear :)
Updated with your suggestion (thanks!), and also added a small whatsnew section.

@saimn saimn removed the Bug label Oct 18, 2023
@astrofrog
astrofrog merged commit b322c76 into astropy:main Oct 19, 2023
@saimn
saimn deleted the fits-decompress-in-memory branch October 19, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reading gzipped FITS file is slow

3 participants