update nduncertainty for multiple/divide #1547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out the nddata and nduncertainity classes, I noticed that the propagation of errors for multiple/divide did not work. The problem was that in propagate_divide and propagate_multiply they were calling a self.data that didn't exist. To fix this problem, I changed self.data to self.parent_nddata.data in those two tasks. I also added 'self._parent_nddata=value' to the setter function for parent_nddata.
In addition, I added two tests to test_nddata to test for propogation of errors when using multiply and divide.