Skip to content

Add support for new np.linalg.diagonal and trace - #15469

Merged
pllim merged 1 commit into
astropy:mainfrom
mhvk:units-function-coverage-for-numpy2
Oct 11, 2023
Merged

Add support for new np.linalg.diagonal and trace#15469
pllim merged 1 commit into
astropy:mainfrom
mhvk:units-function-coverage-for-numpy2

Conversation

@mhvk

@mhvk mhvk commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Description

This pull request is to ensure the new np.linalg.diagonal and np.linalg.trace added in numpy 2.0 are supported for quantities.

Fixes #15465

Note: devdeps should pass now!

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added this to the v6.0 milestone Oct 11, 2023
@mhvk
mhvk requested a review from pllim October 11, 2023 16:13
@github-actions

github-actions Bot commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk mhvk mentioned this pull request Oct 11, 2023
Closed
@mhvk

mhvk commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

devdeps passed!

pllim
pllim approved these changes Oct 11, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! I would have never been able to figure it out... 😅

@pllim
pllim enabled auto-merge October 11, 2023 16:31
@mhvk

mhvk commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the quick fix! I would have never been able to figure it out... 😅

That probably means I should comment the test file better... For another time!

@pllim
pllim merged commit 9a9159a into astropy:main Oct 11, 2023
@mhvk
mhvk deleted the units-function-coverage-for-numpy2 branch October 11, 2023 17:14
@neutrinoceros neutrinoceros mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Bug no-changelog-entry-needed numpy-dev units

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

TST: TestFunctionHelpersCompleteness.test_all_included fails with numpy-dev

2 participants

@mhvk @pllim