Repository navigation
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
5c49521 to
38170d8
Compare
|
I worry about 300 days being too long - see comment in #14756. You are right that the line for the leap-second file has to be changed. With a value larger than 180, the code will assume that even leap second files that are expired are "good enough" -- and then give a warning because the file is expired at the end. Offsets smaller than 0 should definitely not be allowed. |
|
From the new discussions in #14756 , sounds like I should just close this without merge while you all debate somemore? |
|
Given the failures, I think the very simple solution does not work, so maybe indeed best to just abandon for now... I think the people bothered by the short update time should find a solution that does not break the workflow of those who rely on it... |
The people who are bothered are the service providers, unfortunately. Users can opt to turn download off (we have a whole section of doc dedicated to that) but providers cannot control who requests their files. |
|
I also proposed this but was rejected: |
|
Anyway, let's move the discussion back to the original issue. Thanks! |
Description
This pull request is to increase the default value of
auto_max_agefrom 30 days to 300 days. The main goal is to reduce network hit from IERS related lookups.I cannot tell if this needs updating (I did not touch it in the initial commit):
astropy/astropy/utils/iers/iers.py
Line 1130 in e27b224
Fixes #14756