Skip to content

Handle ruff error RET508. - #15406

Merged
pllim merged 1 commit into
astropy:mainfrom
draghuram:ruff-RET508
Oct 3, 2023
Merged

Handle ruff error RET508.#15406
pllim merged 1 commit into
astropy:mainfrom
draghuram:ruff-RET508

Conversation

@draghuram

@draghuram draghuram commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Description

This pull request is to address ruff error RET508. Some times, it is more readable to have an explicit "else" clause but I agree that in most cases, it is better not to have it. It reduces the indentation and makes the code more readable.

Changes need to be reviewed carefully though all tests pass and the diff looks fine to me.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

github-actions Bot commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v6.0 milestone Sep 29, 2023
nstarman
nstarman reviewed Sep 30, 2023
View reviewed changes

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most stuff looks good. I think the votable tree can do with a more artful pruning.

Comment thread astropy/io/votable/tree.py Resolved
@draghuram
Handle ruff error RET508.
e9df6d7 
Signed-off-by: Raghuram Devarakonda <[email protected]>
nstarman
nstarman reviewed Sep 30, 2023
View reviewed changes

@nstarman nstarman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much cleaner! I like that we get to decent the whole thing and reduce all the breaks to 1 (+ a continue) 👍

@nstarman

nstarman commented Sep 30, 2023

Copy link
Copy Markdown
Member

Let's let a io-votable maintainer take a look. Ping @pllim @tomdonaldson @tboch

pllim
pllim reviewed Sep 30, 2023
View reviewed changes
Comment thread astropy/io/votable/tree.py Resolved
mhvk
mhvk approved these changes Oct 1, 2023
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look like improvements to me, thanks! (approving units and table in particular, though really all look good)

@pllim pllim mentioned this pull request Oct 2, 2023
Merged
1 task
pllim
pllim approved these changes Oct 3, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for io.votable.

Thanks!

@pllim
pllim merged commit fff1973 into astropy:main Oct 3, 2023
@pllim pllim mentioned this pull request Oct 3, 2023
Merged
1 task done
@draghuram
draghuram deleted the ruff-RET508 branch October 4, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz left review comments
@nstarman nstarman nstarman left review comments
@pllim pllim pllim approved these changes
@mhvk mhvk mhvk approved these changes
@WilliamJamieson WilliamJamieson Awaiting requested review from WilliamJamieson WilliamJamieson is a code owner
@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner
@saimn saimn Awaiting requested review from saimn saimn is a code owner
@dhomeier dhomeier Awaiting requested review from dhomeier dhomeier is a code owner

Assignees

No one assigned

Labels

io.ascii io.fits io.votable no-changelog-entry-needed table units

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@draghuram @nstarman @pllim @mhvk @bsipocz