Repository navigation
Allow the use of Distribution in Representations and SkyCoord - #15395
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
mhvk
force-pushed
the
distribution-representations
branch
from
September 27, 2023 13:26
b4521d2 to
1e04dcc
Compare
2 tasks
nstarman
reviewed
Sep 27, 2023
nstarman
left a comment
nstarman
left a comment
Member
There was a problem hiding this comment.
It's wonderful how few changes are actually required!
| if cls.__name__ == "BaseRepresentation": | ||
| # Register representation name (except for bases on which other representations | ||
| # are built, but which cannot themselves be used). | ||
| if cls.__name__.startswith("Base"): |
Member
There was a problem hiding this comment.
This is good given the current check, but it would be nice to have a check not based on strings but on e.g. if the class is abstract.
Contributor
Author
There was a problem hiding this comment.
Agreed that this is not a very nice heuristic... But for another time!
Also adjust broadcast_arrays to ensure that regular arrays are not turned into Distribution after broadcasting.
mhvk
force-pushed
the
distribution-representations
branch
from
September 27, 2023 16:22
1e04dcc to
446bbb5
Compare
mhvk
force-pushed
the
distribution-representations
branch
from
September 27, 2023 17:58
446bbb5 to
9de420c
Compare
nstarman
approved these changes
Oct 1, 2023
nstarman
left a comment
nstarman
left a comment
Member
There was a problem hiding this comment.
LGTM! I like the code / test ratio.
We've identified some things for followup, so this PR is ready.
Probably want other Coordinates maintainers to OK this?
Contributor
Author
|
Thanks! I asked @eteq offline for a quick review, as the other |
Member
|
@mhvk , I'll leave it to your discretion on when to merge then. But I would advise against waiting till the last minute before feature freeze. |
Contributor
Author
|
Thanks, all, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is updates the
Distributionclass to allow it to be used inside representations. After the PRs to get things to work withEarthLocation, the changes here are rather minimal: supportconcatenateand a small fix in howbroadcast_arraysis dealt with (plus a very small change in registration of representations, just for the tests to work more easily); the bulk of this PR is extra tests.Note that the support is not yet complete. E.g., the way representations do
__repr__means that thereprgives no sign that distributions are used. I think the best way to fix this, though, is through support ofarray2stringfor representations, which is a bit beyond what I can do here (similarly,Distribution.__repr__should go viaarray2stringso that one can indicate what are the samples more easily). There perhaps also is a more general question of whether things likeSkyCoordshould just allowDistributionto be used, or whether they should also gain a.distributionproperty.Anyway, I think it makes sense to proceed in small steps, so just go with what is here first...