Skip to content

Backport PR #15298 on branch v5.3.x (Address ruff's DTZ003 rule violations) - #15371

Merged
pllim merged 1 commit into
astropy:v5.3.xfrom
pllim:backport-of-pr-15298-on-v5.3.x
Sep 22, 2023
Merged

pllim merged 1 commit into
astropy:v5.3.xfrom
pllim:backport-of-pr-15298-on-v5.3.x

Conversation

@pllim

@pllim pllim commented Sep 22, 2023 •

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport #15298 . This is required for #15370 .

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim

pllim commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

This is a manual backport of something that was already reviewed, so merging.

@pllim
pllim marked this pull request as ready for review September 22, 2023 00:53
@pllim
pllim requested a review from taldcroft as a code owner September 22, 2023 00:53
@pllim
pllim merged commit 544714a into astropy:v5.3.x Sep 22, 2023
@pllim
pllim deleted the backport-of-pr-15298-on-v5.3.x branch September 22, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant