Skip to content

TST: test_api_lookup also catches TimeoutError in CI - #15355

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:test_api_lookup_timeout
Sep 20, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
pllim:test_api_lookup_timeout

Conversation

@pllim

@pllim pllim commented Sep 20, 2023

Copy link
Copy Markdown
Member

Description

This pull request is like #15322 but for a different remote data test.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Sep 20, 2023
6 tasks done
@pllim

pllim commented Sep 20, 2023

Copy link
Copy Markdown
Member Author

Should be uncontroversial. Just gonna merge so I don't have to deal with this failure in unrelated PRs.

@pllim
pllim merged commit f1c0f68 into astropy:main Sep 20, 2023
@pllim
pllim deleted the test_api_lookup_timeout branch September 20, 2023 19:31
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 20, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 20, 2023
pllim added a commit that referenced this pull request Sep 20, 2023
…355-on-v5.3.x

Backport PR #15355 on branch v5.3.x (TST: test_api_lookup also catches TimeoutError in CI)
pllim added a commit that referenced this pull request Sep 20, 2023
…355-on-v5.0.x

Backport PR #15355 on branch v5.0.x (TST: test_api_lookup also catches TimeoutError in CI)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant