Skip to content

Backport PR #15339 on branch v5.3.x (Attempt to fix wheel building), removed parallel-and-32bit job - #15340

Merged
pllim merged 2 commits into
astropy:v5.3.xfrom
meeseeksmachine:auto-backport-of-pr-15339-on-v5.3.x
Sep 18, 2023
Merged

pllim merged 2 commits into
astropy:v5.3.xfrom
meeseeksmachine:auto-backport-of-pr-15339-on-v5.3.x

Conversation

@meeseeksmachine

Copy link
Copy Markdown

Backport PR #15339: Attempt to fix wheel building

@lumberbot-app lumberbot-app Bot added this to the v5.3.4 milestone Sep 18, 2023
@lumberbot-app lumberbot-app Bot added testing installation build no-changelog-entry-needed Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection backport-v5.3.x labels Sep 18, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Sep 18, 2023

Copy link
Copy Markdown
Member

Tsk tsk... Doesn't quite make sense to backport #15018 since cron job does not run automatically for backport branches. Should we just remove the 32-bit job for v5.3.x ?

@pllim
pllim force-pushed the auto-backport-of-pr-15339-on-v5.3.x branch from 90d6709 to dce0d4e Compare September 18, 2023 17:43
@pllim
pllim merged commit 4472a07 into astropy:v5.3.x Sep 18, 2023
@pllim pllim changed the title Backport PR #15339 on branch v5.3.x (Attempt to fix wheel building) Backport PR #15339 on branch v5.3.x (Attempt to fix wheel building), removed parallel-and-32bit job Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build all wheels Run all the wheel builds rather than just a selection build Extra CI Run cron CI as part of PR installation no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants