Skip to content

Attempt to fix wheel building - #15339

Merged
pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/building
Sep 18, 2023
Merged

Attempt to fix wheel building#15339
pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/building

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented Sep 18, 2023 •
edited by pllim
Loading

Copy link
Copy Markdown
Contributor

This pull request tries again to fix partially #15333 (for normal wheels). It is my attempt at my suggestion in #15338 (comment).

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@WilliamJamieson WilliamJamieson added testing build no-changelog-entry-needed Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection backport-v5.3.x labels Sep 18, 2023
@github-actions

github-actions Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim added this to the v5.3.4 milestone Sep 18, 2023
@WilliamJamieson
WilliamJamieson force-pushed the bugfix/building branch 2 times, most recently from b68b8fb to 1b0f9ed Compare September 18, 2023 15:54
@WilliamJamieson
WilliamJamieson marked this pull request as ready for review September 18, 2023 16:32
WilliamJamieson
WilliamJamieson commented Sep 18, 2023
View reviewed changes
Comment thread pyproject.toml
Comment on lines -27 to -31
[[tool.cibuildwheel.overrides]]
# Python 3.11 and later is not available in manylinux2010 so we only
# set this for Python<=3.10.
select = "cp3{8,9,10}-*"
manylinux-x86_64-image = "manylinux2010"

@WilliamJamieson WilliamJamieson Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I determined we needed manylinux2014, for the new numpy versions which is the default for CI build wheel

@pllim

pllim commented Sep 18, 2023

Copy link
Copy Markdown
Member

LGTM on the normal wheels. Thanks! We can handle the "exotic archs" separately in a follow-up PR (so I will mark this PR as not entirely fix the issue it set out to fix). This alone should hopefully unblock a majority of PRs we have, except for those that request "Extra CI".

@astrofrog , if you disagree with this particular patch, feel free to open a follow-up PR.

p.s. devdeps refuses to pick up dev numpy because of matplotlib/matplotlib#26786 (i.e., stable matplotlib pins numpy<2). Nothing much we can do about that until matplotlib gets a 3.9.dev wheel out. And this problem is unrelated to the wheels.

@pllim
pllim merged commit 8e95fbd into astropy:main Sep 18, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 18, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 18, 2023
@pllim @meeseeksmachine
Backport PR astropy#15339: Attempt to fix wheel building
dc41f06
@pllim pllim mentioned this pull request Sep 18, 2023
Closed
pllim added a commit that referenced this pull request Sep 18, 2023
@pllim
Merge pull request #15340 from meeseeksmachine/auto-backport-of-pr-15…
4472a07 
…339-on-v5.3.x

Backport PR #15339 on branch v5.3.x (Attempt to fix wheel building)
@WilliamJamieson
WilliamJamieson deleted the bugfix/building branch September 18, 2023 19:19
@WilliamJamieson WilliamJamieson mentioned this pull request Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes
@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees

No one assigned

Labels

Build all wheels Run all the wheel builds rather than just a selection build Extra CI Run cron CI as part of PR installation no-changelog-entry-needed testing

Projects

None yet

Milestone

v5.3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamJamieson @pllim