Skip to content

BLD: Use manylinux2 - #15338

Closed
pllim wants to merge 1 commit into
astropy:mainfrom
pllim:monday-wheels-fun
Closed

BLD: Use manylinux2#15338
pllim wants to merge 1 commit into
astropy:mainfrom
pllim:monday-wheels-fun

Conversation

@pllim

@pllim pllim commented Sep 18, 2023

Copy link
Copy Markdown
Member

Description

Fix #15333 maaaaaybe

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added build no-changelog-entry-needed Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection backport-v5.3.x labels Sep 18, 2023
@pllim pllim added this to the v5.3.4 milestone Sep 18, 2023
@github-actions

github-actions Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim

pllim commented Sep 18, 2023

Copy link
Copy Markdown
Member Author

Still does not explain why these also are failing. We grab from Ubuntu (rolling) via python3-numpy.

          - arch: s390x
          - arch: ppc64le
          - arch: armv7

@pllim

pllim commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Nope, doesn't work. I see this in the log, seems to come from cibuildwheel itself.

manylinux_images: 
    x86_64: quay.io/pypa/manylinux2014_x86_64:2023-08-07-e3f636d
    i686: quay.io/pypa/manylinux2014_i686:2023-08-07-e3f636d
    pypy_x86_64: quay.io/pypa/manylinux2014_x86_64:2023-08-07-e3f636d
    aarch64: quay.io/pypa/manylinux2014_aarch64:2023-08-07-e3f636d
    ppc64le: quay.io/pypa/manylinux2014_ppc64le:2023-08-07-e3f636d
    s390x: quay.io/pypa/manylinux2014_s390x:2023-08-07-e3f636d
    pypy_aarch64: quay.io/pypa/manylinux2014_aarch64:2023-08-07-e3f636d
    pypy_i686: quay.io/pypa/manylinux2014_i686:2023-08-07-e3f636d
  musllinux_images: 
    x86_64: quay.io/pypa/musllinux_1_1_x86_64:2023-08-07-e3f636d
    i686: quay.io/pypa/musllinux_1_1_i686:2023-08-07-e3f636d
    aarch64: quay.io/pypa/musllinux_1_1_aarch64:2023-08-07-e3f636d
    ppc64le: quay.io/pypa/musllinux_1_1_ppc64le:2023-08-07-e3f636d
    s390x: quay.io/pypa/musllinux_1_1_s390x:2023-08-07-e3f636d

WilliamJamieson
WilliamJamieson reviewed Sep 18, 2023
View reviewed changes
Comment thread .github/workflows/publish.yml
test_command: pytest -p no:warnings --astropy-header -m "not hypothesis" -k "not test_data_out_of_range and not test_set_locale and not TestQuantityTyping" --pyargs astropy
targets: |
- cp39-manylinux_x86_64
- cp39-manylinux2_x86_64

@WilliamJamieson WilliamJamieson Sep 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is what you need to be changing. Instead:

astropy/pyproject.toml

Line 31 in 763ee0c

manylinux-x86_64-image = "manylinux2010"

should be changed to

manylinux-x86_64-image = "manylinux2014"

@pllim pllim Sep 18, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear lord. Since when we do this in pyproject.toml ? Thanks for pointing that out.

@pllim pllim Sep 18, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I just remove the entire override? Seems pointless now.

@pllim pllim Sep 18, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

William will take over in a separate PR. I should not be doing this today anyway.

@pllim pllim closed this Sep 18, 2023
@pllim
pllim deleted the monday-wheels-fun branch September 18, 2023 15:40
@WilliamJamieson WilliamJamieson mentioned this pull request Sep 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamJamieson WilliamJamieson WilliamJamieson left review comments
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros will be requested when the pull request is marked ready for review neutrinoceros is a code owner

Assignees

No one assigned

Labels

Build all wheels Run all the wheel builds rather than just a selection build Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

None yet

Milestone

v5.3.4

Development

Successfully merging this pull request may close these issues.

CI wheel building broken due to numpy 1.26 (exotic archs)

2 participants

@pllim @WilliamJamieson