Skip to content

Backport PR #15326 on branch v5.3.x (TestMaskedQuantityInitialization: Fix initialization)#15335

Merged
pllim merged 1 commit intoastropy:v5.3.xfrom
meeseeksmachine:auto-backport-of-pr-15326-on-v5.3.x
Sep 18, 2023
Merged

Backport PR #15326 on branch v5.3.x (TestMaskedQuantityInitialization: Fix initialization)#15335
pllim merged 1 commit intoastropy:v5.3.xfrom
meeseeksmachine:auto-backport-of-pr-15326-on-v5.3.x

Conversation

@meeseeksmachine
Copy link

Backport PR #15326: TestMaskedQuantityInitialization: Fix initialization

@github-actions
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failures are unrelated.

@pllim pllim merged commit 9124575 into astropy:v5.3.x Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants