Skip to content

TST: test_find_invalid might also cause TimeoutError - #15322

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:relax-bad-url-check
Sep 15, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
pllim:relax-bad-url-check

Conversation

@pllim

@pllim pllim commented Sep 15, 2023

Copy link
Copy Markdown
Member

Description

test_find_invalid might also cause TimeoutError sometimes, maybe when service provider blocks CI

Fixes #15321

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

sometimes, maybe when service provider blocks CI
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim pllim mentioned this pull request Sep 15, 2023
6 tasks done
@pllim
pllim marked this pull request as ready for review September 15, 2023 21:48
@pllim

pllim commented Sep 15, 2023

Copy link
Copy Markdown
Member Author

I don't think this is controversial so I am just gonna merge it because I want my other PR touching devdeps to be green.

The point of the test is to proof that calling a non-existent file throws exception, doesn't matter much to me if it is URLError or TimeoutError.

@pllim
pllim merged commit 85ab36a into astropy:main Sep 15, 2023
@pllim
pllim deleted the relax-bad-url-check branch September 15, 2023 22:03
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 15, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 15, 2023
pllim added a commit that referenced this pull request Sep 15, 2023
…322-on-v5.0.x

Backport PR #15322 on branch v5.0.x (TST: test_find_invalid might also cause TimeoutError)
pllim added a commit that referenced this pull request Sep 15, 2023
…322-on-v5.3.x

Backport PR #15322 on branch v5.3.x (TST: test_find_invalid might also cause TimeoutError)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: test_find_invalid throws TimeoutError instead of URLError now

1 participant