Repository navigation
TST: test_find_invalid might also cause TimeoutError - #15322
Merged
Merged
Conversation
sometimes, maybe when service provider blocks CI
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Contributor
|
👋 Thank you for your draft pull request! Do you know that you can use |
6 tasks done
pllim
marked this pull request as ready for review
September 15, 2023 21:48
Member
Author
|
I don't think this is controversial so I am just gonna merge it because I want my other PR touching devdeps to be green. The point of the test is to proof that calling a non-existent file throws exception, doesn't matter much to me if it is URLError or TimeoutError. |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Sep 15, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Sep 15, 2023
pllim
added a commit
that referenced
this pull request
Sep 15, 2023
…322-on-v5.0.x Backport PR #15322 on branch v5.0.x (TST: test_find_invalid might also cause TimeoutError)
pllim
added a commit
that referenced
this pull request
Sep 15, 2023
…322-on-v5.3.x Backport PR #15322 on branch v5.3.x (TST: test_find_invalid might also cause TimeoutError)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_find_invalidmight also cause TimeoutError sometimes, maybe when service provider blocks CIFixes #15321