Skip to content

DOC: Fix cosmology doctest failure on s390x - #15165

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:cosmo-doctest-s390x
Aug 12, 2023
Merged

DOC: Fix cosmology doctest failure on s390x#15165
pllim merged 1 commit into
astropy:mainfrom
pllim:cosmo-doctest-s390x

Conversation

@pllim

@pllim pllim commented Aug 12, 2023

Copy link
Copy Markdown
Member

Description

This pull request is to address cosmology doctest failure that somehow only pops up on s390x cron job. This is cherry-picked from #15102 by @nstarman .

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v5.3.2 milestone Aug 12, 2023
@pllim
pllim requested a review from a team as a code owner August 12, 2023 18:54
@pllim
pllim requested a review from nstarman August 12, 2023 18:54
@github-actions

github-actions Bot commented Aug 12, 2023 •
edited by nstarman
Loading

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Aug 12, 2023
Merged
@nstarman
nstarman enabled auto-merge August 12, 2023 18:58
@pllim
pllim disabled auto-merge August 12, 2023 19:00
@pllim

pllim commented Aug 12, 2023

Copy link
Copy Markdown
Member Author

@nstarman , cannot auto merge this one because the job that is relevant is not "required" to pass. So I disabled auto-merge. FYI.

@pllim pllim modified the milestones: v5.3.2, v6.0 Aug 12, 2023
@pllim

pllim commented Aug 12, 2023

Copy link
Copy Markdown
Member Author

I don't see this failure in v5.3.x so decided not to backport.

@pllim
pllim enabled auto-merge August 12, 2023 22:17
@pllim
pllim merged commit 291414a into astropy:main Aug 12, 2023
@pllim
pllim deleted the cosmo-doctest-s390x branch August 12, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nstarman nstarman nstarman approved these changes

Assignees

No one assigned

Labels

cosmology Docs Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

Cosmology, the Expansion
Status: Done

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @nstarman