Skip to content

cosmo module core -> _core - #15126

Closed
nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:cosmo-core-private
Closed

nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:cosmo-core-private

Conversation

@nstarman

@nstarman nstarman commented Aug 5, 2023

Copy link
Copy Markdown
Member

Cleaning up import paths. Let there only be one import of Cosmology!

@nstarman nstarman added this to the v6.0 milestone Aug 5, 2023
@github-actions

github-actions Bot commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman changed the title core -> _core cosmo module core -> _core Aug 13, 2023
@nstarman
nstarman marked this pull request as ready for review August 13, 2023 15:40
@nstarman
nstarman requested a review from a team as a code owner August 13, 2023 15:40
@nstarman
nstarman requested review from eerovaher and mhvk and removed request for a team August 13, 2023 15:40
@mhvk

mhvk commented Aug 13, 2023

Copy link
Copy Markdown
Contributor

Taking myself off the reviewer list since I still dislike private modules...

@mhvk
mhvk removed their request for review August 13, 2023 15:58
@mhvk

mhvk commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

Thinking more (mostly because of #15166, which affects utils), I think it would be good to have a more package-wide policy on how we indicate that submodules are private (in the sense that they should not be used to import from) -- see #15169. Note that I feel much more strongly about consistency than exactly what the plan is (and if cosmology deviates, perhaps that's OK too, but utils is another story).

@saimn saimn modified the milestones: v6.0, v6.1 Oct 28, 2023
@astrofrog astrofrog modified the milestones: v6.1.0, v7.0.0 Apr 4, 2024
@nstarman
nstarman force-pushed the cosmo-core-private branch from 263eb8f to 6e76476 Compare April 16, 2024 22:28
Signed-off-by: nstarman <[email protected]>
@nstarman
nstarman force-pushed the cosmo-core-private branch from 6e76476 to 86ea96a Compare April 16, 2024 22:38
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Sep 14, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@github-actions github-actions Bot added the closed-by-bot Closed by stale bot label Oct 15, 2024
@github-actions

Copy link
Copy Markdown
Contributor

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

@github-actions github-actions Bot closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close? Tell stale bot that this issue/PR is stale closed-by-bot Closed by stale bot cosmology no-changelog-entry-needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants