Skip to content

simple matter-radiation equality function - #15110

Draft
nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:matter-radiation-equality
Draft

nstarman wants to merge 1 commit into
astropy:mainfrom
nstarman:matter-radiation-equality

Conversation

@nstarman

@nstarman nstarman commented Aug 1, 2023

Copy link
Copy Markdown
Member

Convenience function to calculate matter radiation equality.

@nstarman nstarman added this to the v6.0 milestone Aug 1, 2023
@github-actions

github-actions Bot commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman
nstarman force-pushed the matter-radiation-equality branch 4 times, most recently from 7982b12 to 146fe19 Compare August 13, 2023 19:18
@nstarman
nstarman force-pushed the matter-radiation-equality branch 2 times, most recently from fa9a2db to 2b2d60b Compare August 24, 2023 16:18
@saimn saimn modified the milestones: v6.0, v6.1 Oct 28, 2023
@nstarman
nstarman force-pushed the matter-radiation-equality branch 2 times, most recently from a3106f1 to df82e9c Compare January 16, 2024 06:31
@nstarman
nstarman force-pushed the matter-radiation-equality branch from 32e73c0 to 2f60f88 Compare January 20, 2024 19:51
@astrofrog astrofrog modified the milestones: v6.1.0, v7.0.0 Apr 4, 2024
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Jun 19, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@nstarman nstarman added keep-open and removed Close? Tell stale bot that this issue/PR is stale labels Jun 19, 2024
@nstarman

Copy link
Copy Markdown
Member Author

What this needs is more rigorous tests. I'll get around to it.

@neutrinoceros

Copy link
Copy Markdown
Contributor

@nstarman do you want to come back to this very soon, or should we bump/remove the milestone ?

@nstarman nstarman modified the milestones: v7.0.0, v7.1.0 Oct 17, 2024
@astrofrog astrofrog modified the milestones: v7.1.0, v7.2.0 Apr 28, 2025
@nstarman

Copy link
Copy Markdown
Member Author

Held up because we don't have a nice omega_radiation.
But we have a particular treatment of neutrinos. Gotta think about this one.

@astrofrog astrofrog removed this from the v7.2.0 milestone Nov 3, 2025
@astrofrog astrofrog added this to the v8.0.0 milestone Nov 3, 2025
@astrofrog astrofrog modified the milestones: v8.0.0, v8.1.0 May 5, 2026
@pllim pllim removed the keep-open label Oct 14, 2026
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 2 years. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close? Tell stale bot that this issue/PR is stale cosmology

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants