Skip to content

Cosmo realizations docs - #15102

Merged
nstarman merged 4 commits into
astropy:mainfrom
nstarman:cosmo-parameters-docstring
Aug 12, 2023
Merged

nstarman merged 4 commits into
astropy:mainfrom
nstarman:cosmo-parameters-docstring

Conversation

@nstarman

@nstarman nstarman commented Jul 31, 2023 •

Copy link
Copy Markdown
Member

@nstarman nstarman added this to the v6.0 milestone Jul 31, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@nstarman nstarman changed the title Cosmo parameters docstring Cosmo realizations docs Jul 31, 2023
@nstarman
nstarman marked this pull request as ready for review July 31, 2023 18:05
@nstarman
nstarman requested a review from a team as a code owner July 31, 2023 18:05
@nstarman
nstarman requested a review from mhvk July 31, 2023 18:05
@nstarman
nstarman force-pushed the cosmo-parameters-docstring branch 2 times, most recently from 9e27d23 to a2c0aaf Compare August 5, 2023 00:51
It’s definitionally true and there’s now a property ``is_flat``.

Signed-off-by: nstarman <[email protected]>
@nstarman
nstarman force-pushed the cosmo-parameters-docstring branch from 0264ca7 to c57c6d0 Compare August 7, 2023 01:53
@nstarman
nstarman force-pushed the cosmo-parameters-docstring branch from c57c6d0 to ea47c4e Compare August 7, 2023 02:17
@nstarman
nstarman requested a review from eerovaher August 7, 2023 18:07
@nstarman

Copy link
Copy Markdown
Member Author

Ping @mhvk, as part or #15096

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice reorganization!

@nstarman
nstarman merged commit 598a05a into astropy:main Aug 12, 2023
@nstarman
nstarman deleted the cosmo-parameters-docstring branch August 12, 2023 20:27
@nstarman nstarman mentioned this pull request Aug 12, 2023
10 of 11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants