Skip to content

Update WCSLIB to version 8.1 - #15035

Merged
mcara merged 1 commit into
astropy:mainfrom
mcara:update-wcslib-8p1
Jul 7, 2023
Merged

Update WCSLIB to version 8.1#15035
mcara merged 1 commit into
astropy:mainfrom
mcara:update-wcslib-8p1

Conversation

@mcara

@mcara mcara commented Jul 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR updates built-in WCSLIB distributed with astropy. Excerpts from WCSLIB's changelog:

WCSLIB version 8.1 (2023/07/06)
-------------------------------

Changes in the contents of the auxprm struct (in 8.0 beta) necessitated
incrementing the major version number from 7 to 8, i.e. the ABI changed.
Took the opportunity for minor tweaks to wcsprm and disprm.

* C library

  - In disprm, changed the order of maxdis and totdis to ensure correct
    alignment of doubles on 32-bit machines.

WCSLIB version 8.0 beta (2023/07/01)
------------------------------------

Beta test version, not publically released.

* C library

  - Support planetary keywords A_RADIUS, B_RADIUS, C_RADIUS, BLON_OBS,
    BLAT_OBS, and BDIS_OBS in auxprm by analogy with the Solar keywords
    added at 7.1.  Requested by Chiara Marmo (Observatoire de Paris).

  - Added wcsprm::time to the wcsprm struct to record the TIME axis
    number (along with lng, lat, and spec).

  - Fixed a bug in wcspih() and wcsbth() where trailing blanks were not
    stripped from string keyvalues.  Reported by Naveen Dukiya.

  - Fixed a problem affecting thread safety in disp2x(), disx2p(), and
    diswarp().  Reported by Mohammad Akhlaghi.

For a full list of changes, see WCSLIB's CHANGELOG
or astropy/cextern/wcslib/CHANGES

This update is to support work on #14820.

Many thanks to @cmarmo !

@mcara mcara self-assigned this Jul 6, 2023
@mcara mcara added wcs external PRs and issues related to external packages vendored with Astropy (astropy.extern) labels Jul 6, 2023
@mcara
mcara requested a review from dhomeier July 6, 2023 19:27
@github-actions

github-actions Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mcara mcara added this to the v5.3.1 milestone Jul 6, 2023
@mcara
mcara requested review from mhvk and pllim July 6, 2023 19:29
@mcara
mcara force-pushed the update-wcslib-8p1 branch from 9fb2ea7 to a342924 Compare July 6, 2023 20:05
@mcara mcara mentioned this pull request Jul 6, 2023
Merged
@mcara
mcara requested a review from nden July 6, 2023 20:19
nden
nden approved these changes Jul 6, 2023
View reviewed changes

@nden nden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pllim
pllim requested changes Jul 6, 2023
View reviewed changes
Comment thread docs/changes/wcs/15035.feature.rst Resolved
@mcara mcara modified the milestones: v5.3.1, v5.3.2 Jul 7, 2023
@mcara
mcara requested a review from pllim July 7, 2023 01:24
@mcara
mcara enabled auto-merge July 7, 2023 01:25
@mcara mcara modified the milestones: v5.3.2, v6.0 Jul 7, 2023
pllim
pllim approved these changes Jul 7, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mihai and I discussed the milestone offline. We agreed now that this does not need to be backported, so it will land in v6.0. Thanks, all!

@mcara
mcara merged commit 015bb1c into astropy:main Jul 7, 2023
@pllim

pllim commented Jul 7, 2023

Copy link
Copy Markdown
Member

@cmarmo , you can pick this up now if you rebase. 😸

pllim added a commit that referenced this pull request Jul 7, 2023
@pllim
Fix change log for #15035
d59d7fa 
because it creates duplicate explicit target name warning in RTD

[ci skip]
@pllim

pllim commented Jul 7, 2023

Copy link
Copy Markdown
Member

FYI, I had to fix your change log in d59d7fa because RTD was failing with a warning:

docs/changelog.rst:5: WARNING: Duplicate explicit target name: "astropy/cextern/wcslib/changes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nden nden nden approved these changes
@pllim pllim pllim approved these changes
@dhomeier dhomeier Awaiting requested review from dhomeier
@mhvk mhvk Awaiting requested review from mhvk

Assignees

@mcara mcara

Labels

external PRs and issues related to external packages vendored with Astropy (astropy.extern) wcs

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@mcara @pllim @nden