Skip to content

Drop support for Numpy 1.21 - #15006

Merged
pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:feature/drop_np_1_21
Jul 25, 2023
Merged

Drop support for Numpy 1.21#15006
pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:feature/drop_np_1_21

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented Jun 30, 2023 •
edited by pllim
Loading

Copy link
Copy Markdown
Contributor

Blocked by:

Description

NEP 29 and APE 18 indicate that on June 23, 2023, support for numpy 1.21 was dropped.

This pull request removes numpy 1.21 support from astropy.

Should naturally close #15007

@github-actions

github-actions Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@WilliamJamieson

WilliamJamieson commented Jun 30, 2023

Copy link
Copy Markdown
Contributor Author

@pllim, numpy 1.22 no longer provides 32 bit wheels via PyPi, should we drop the 32 bit support?

@WilliamJamieson WilliamJamieson mentioned this pull request Jun 30, 2023
Closed
@pllim

pllim commented Jul 2, 2023

Copy link
Copy Markdown
Member

Let's see what is the consensus over at #15007 first. Thanks!

@pllim pllim added this to the v6.0 milestone Jul 2, 2023
@WilliamJamieson

WilliamJamieson commented Jul 5, 2023

Copy link
Copy Markdown
Contributor Author

PR #15018 moves the 32bit CI tests to the Weekly cron and adjusts the double and parallel jobs.

@WilliamJamieson
WilliamJamieson marked this pull request as ready for review July 16, 2023 18:53
matteobachetti
matteobachetti reviewed Jul 17, 2023
View reviewed changes

@matteobachetti matteobachetti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in io.misc is trivial, no issues there

pllim
pllim requested changes Jul 24, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff LGTM but as discussed offline, this needs a squash and rebase. And then we have to slap a "Extra CI" label on it to run cron jobs here too before merge. Thanks!

@WilliamJamieson
Drop support for Numpy 1.21
3beb2f4 
Update CI

Remove numpy < 1.21.1 code

Remove numpy < 1.22
This is safe because numpy >= 1.22 now.

try to fix modeling

Add changelog
@WilliamJamieson WilliamJamieson added the Extra CI Run cron CI as part of PR label Jul 25, 2023
pllim
pllim approved these changes Jul 25, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks!

@pllim
pllim merged commit 278af12 into astropy:main Jul 25, 2023
@pllim

pllim commented Jul 25, 2023

Copy link
Copy Markdown
Member

Memo sent out to astropy-dev and Slack.

@WilliamJamieson
WilliamJamieson deleted the feature/drop_np_1_21 branch July 25, 2023 19:50
@pllim pllim mentioned this pull request Aug 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matteobachetti matteobachetti matteobachetti left review comments
@pllim pllim pllim approved these changes
@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner
@saimn saimn Awaiting requested review from saimn saimn is a code owner

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR installation testing

Projects

None yet

Milestone

v6.0.0

Development

Successfully merging this pull request may close these issues.

Should astropy move 32bit CI to weekly.

3 participants

@WilliamJamieson @pllim @matteobachetti