Skip to content

Backport PR 14771 to v5.3.x ( Revert Gaussian test change from #14718) - #14776

Merged
pllim merged 1 commit into
astropy:v5.3.xfrom
pllim:backport-pr14771-to-v5.3.x
May 7, 2023
Merged

pllim merged 1 commit into
astropy:v5.3.xfrom
pllim:backport-pr14771-to-v5.3.x

Conversation

@pllim

@pllim pllim commented May 6, 2023

Copy link
Copy Markdown
Member

Description

Manual backport of #14771 to v5.3.x

@pllim pllim added this to the v5.3 milestone May 6, 2023
@pllim
pllim requested a review from a team as a code owner May 6, 2023 15:28
@github-actions

github-actions Bot commented May 6, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented May 7, 2023

Copy link
Copy Markdown
Member Author

Just gonna merge so I can make sure the other backport can get the CI all green.

@pllim
pllim merged commit cd1c324 into astropy:v5.3.x May 7, 2023
@pllim
pllim deleted the backport-pr14771-to-v5.3.x branch May 7, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant