Skip to content

Backport PR #14718 on branch v5.3.x (TST: Compat with numpy 1.25.dev) - #14765

Merged
pllim merged 1 commit into
astropy:v5.3.xfrom
meeseeksmachine:auto-backport-of-pr-14718-on-v5.3.x
May 6, 2023
Merged

Backport PR #14718 on branch v5.3.x (TST: Compat with numpy 1.25.dev)#14765
pllim merged 1 commit into
astropy:v5.3.xfrom
meeseeksmachine:auto-backport-of-pr-14718-on-v5.3.x

Conversation

@meeseeksmachine

@meeseeksmachine meeseeksmachine commented May 5, 2023

Copy link
Copy Markdown

Backport PR #14718: TST: Compat with numpy 1.25.dev

@meeseeksmachine
meeseeksmachine requested a review from a team as a code owner May 5, 2023 21:58
@lumberbot-app lumberbot-app Bot added this to the v5.2.3 milestone May 5, 2023
@github-actions

github-actions Bot commented May 5, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented May 5, 2023

Copy link
Copy Markdown
Member

Are these new failures or just something we forgot to backport? 🤯

https://github.com/astropy/astropy/actions/runs/4897867674/jobs/8746410015?pr=14765

pllim
pllim approved these changes May 6, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this first before we can backport the other one.

@pllim
pllim merged commit 8f59f34 into astropy:v5.3.x May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

coordinates Extra CI Run cron CI as part of PR modeling no-changelog-entry-needed numpy-dev

Projects

None yet

Milestone

v5.2.3

Development

Successfully merging this pull request may close these issues.

2 participants

@meeseeksmachine @pllim