Skip to content

Fix numpy-dev deprecation in model Parameter - #14707

Merged
pllim merged 3 commits into
astropy:mainfrom
larrybradley:model-param-value
Apr 28, 2023
Merged

Fix numpy-dev deprecation in model Parameter#14707
pllim merged 3 commits into
astropy:mainfrom
larrybradley:model-param-value

Conversation

@larrybradley

@larrybradley larrybradley commented Apr 28, 2023

Copy link
Copy Markdown
Member

Description

While investigating devdeps CI failures in photutils, I discovered that Parameter.value can give a numpy 1.25+ deprecation warning ("Conversion of an array with ndim > 0 to a scalar "), e.g.:

>>> from astropy.modeling import Parameter
>>> param = Parameter(name="test", default=[1])
>>> param.value
DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)   return np.float64(self._value)

This wasn't caught in devdeps tests because there was no test for it.

With the fix in this PR, the error message changed back for one of the other tests.

@larrybradley larrybradley added this to the v5.3 milestone Apr 28, 2023
@larrybradley
larrybradley requested a review from pllim April 28, 2023 17:37
@larrybradley
larrybradley requested a review from a team as a code owner April 28, 2023 17:37
@github-actions

github-actions Bot commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim approved these changes Apr 28, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but I won't merge yet in case @WilliamJamieson also wants to review. Thanks!

@pllim

pllim commented Apr 28, 2023

Copy link
Copy Markdown
Member

Do we need to backport to v5.2.x and v5.0.x? 🤔

@larrybradley

larrybradley commented Apr 28, 2023

Copy link
Copy Markdown
Member Author

I'm not sure. Let's see what @WilliamJamieson thinks.

@pllim pllim modified the milestones: v5.3, v5.0.7 Apr 28, 2023
@pllim
pllim merged commit 252b1c4 into astropy:main Apr 28, 2023
@lumberbot-app

This comment was marked as resolved.

Sign in to view
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 28, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 28, 2023
@pllim @meeseeksmachine
Backport PR astropy#14707: Fix numpy-dev deprecation in model Parameter
7a6013b
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 28, 2023
@pllim @meeseeksmachine
Backport PR astropy#14707: Fix numpy-dev deprecation in model Parameter
be810a0
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 28, 2023
Merged
@pllim

This comment was marked as resolved.

Sign in to view
@larrybradley
larrybradley deleted the model-param-value branch April 28, 2023 22:31
larrybradley pushed a commit to larrybradley/astropy that referenced this pull request Apr 28, 2023
@pllim @larrybradley
Backport PR astropy#14707: Fix numpy-dev deprecation in model Parameter
f64de03
@pllim pllim mentioned this pull request Apr 29, 2023
Closed
pllim added a commit that referenced this pull request Apr 29, 2023
@pllim
Merge pull request #14716 from meeseeksmachine/auto-backport-of-pr-14…
0d26a02 
…707-on-v5.3.x

Backport PR #14707 on branch v5.3.x (Fix numpy-dev deprecation in model Parameter)
pllim added a commit that referenced this pull request Apr 29, 2023
@pllim
Merge pull request #14715 from meeseeksmachine/auto-backport-of-pr-14…
88eb564 
…707-on-v5.2.x

Backport PR #14707 on branch v5.2.x (Fix numpy-dev deprecation in model Parameter)
@pllim pllim mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes
@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

Assignees

No one assigned

Labels

modeling no-changelog-entry-needed numpy-dev

Projects

None yet

Milestone

v5.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@larrybradley @pllim @WilliamJamieson