Repository navigation
Backport PR #14671 on branch v5.0.x (Fix numpy 1.25 deprecation warnings) - #14686
Merged
pllim merged 1 commit intoApr 27, 2023
Merged
Conversation
pllim
added
skip-basebranch-check
Member
|
Gonna close/re-open to make bot happy. |
Contributor
|
Tests are failing with Why does this happen only in the v5.0.x backport ? |
Member
|
Probably need to patch more because that code was removed in later branches? 😒 |
Member
|
Ugh looks painful. Should we just pin maxversion of numpy in v5.0.x and be done with it? |
Member
|
@WilliamJamieson might follow-up with a patch for the remaining failures. If not, we'll consider pinning a max version of numpy in LTS. Meanwhile, let's just get this in. Doesn't hurt to have either way. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #14671 on branch v5.0.x (Fix numpy 1.25 deprecation warnings)