Skip to content

Update CDS units - #1468

Merged
mdboom merged 6 commits into
astropy:masterfrom
mdboom:unit/cds-extra-units
Oct 21, 2013
Merged

mdboom merged 6 commits into
astropy:masterfrom
mdboom:unit/cds-extra-units

Conversation

@mdboom

@mdboom mdboom commented Sep 20, 2013

Copy link
Copy Markdown
Contributor

CDS has enlarged the list of units it supports [1]. This is a reminder that we should update the cds parser accordingly.

[1] http://vizier.u-strasbg.fr/cgi-bin/Unit

@ghost ghost assigned mdboom Sep 19, 2013
@mdboom

mdboom commented Sep 20, 2013

Copy link
Copy Markdown
Contributor

I have added support for the additional units in the standard. This relies on #1268 to be merged first.

Many of these units are not strictly units, but really constants, so I have added constants to astropy.constants and linked to them from the new astropy.units.cds module. Please check my work on the constants module.

@mhvk

mhvk commented Oct 14, 2013

Copy link
Copy Markdown
Contributor Author

@mdboom - I'm certainly happy seeing this merged, but perhaps someone else should have a look?

@astrofrog

Copy link
Copy Markdown
Member

@mdboom - is astropy.units.cds opt-in? If so, then maybe we should enable it for the CDS ASCII reader? (cc @taldcroft)

@mdboom

mdboom commented Oct 14, 2013

Copy link
Copy Markdown
Contributor

Yes -- I don't think the CDS ascii reader currently returns Unit objects (just the string), but it probably should return unit objects. The CDS support isn't actually new -- this is just closer to the specification (which actually involves multiple unlinked documents) than before.

mdboom added a commit that referenced this pull request Oct 21, 2013
@mdboom
mdboom merged commit 2ccde4d into astropy:master Oct 21, 2013
@mdboom
mdboom deleted the unit/cds-extra-units branch May 21, 2014 23:57
@pllim pllim mentioned this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants