Skip to content

Fix numpy 1.25 deprecation warnings - #14671

Merged
pllim merged 7 commits into
astropy:mainfrom
larrybradley:fix-np125-depr
Apr 24, 2023
Merged

pllim merged 7 commits into
astropy:mainfrom
larrybradley:fix-np125-depr

Conversation

@larrybradley

@larrybradley larrybradley commented Apr 21, 2023 •

Copy link
Copy Markdown
Member

Description

This PR should fix the deprecation warning in numpy-dev, which is currently causing the CI dev test to fail.

Fix #14674

Close #14676

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@larrybradley

Copy link
Copy Markdown
Member Author

Well before this PR only 2 deprecation warnings were reported (e.g., https://github.com/astropy/astropy/actions/runs/4768585591/jobs/8478077374). Those were fixed by this PR, but now's there's a whole bunch more.

@larrybradley larrybradley changed the title Fix numpy 1.25 deprecation warning Fix numpy 1.25 deprecation warnings Apr 24, 2023
@larrybradley

Copy link
Copy Markdown
Member Author

I've updated this PR to fix all the new numpy 1.25 deprecations (and changed error message):

  • Conversion of an array with ndim > 0 to a scalar is deprecated
  • ValueError: setting an array element with a sequence.
  • A ValueError message was changed

Most of the new warnings came from the models subpackage. The base Model.__call__ method wraps the model evaluate methods, but it also turns scalar inputs into arrays before calling evaluate. So in some cases evaluate expects a scalar, but gets an array.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pllim
pllim enabled auto-merge April 24, 2023 22:18
@pllim
pllim merged commit b504794 into astropy:main Apr 24, 2023
@lumberbot-app

This comment was marked as resolved.

meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 24, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Apr 24, 2023
@larrybradley
larrybradley deleted the fix-np125-depr branch April 24, 2023 22:22
larrybradley pushed a commit to larrybradley/astropy that referenced this pull request Apr 24, 2023
saimn added a commit that referenced this pull request Apr 25, 2023
…671-on-v5.2.x

Backport PR #14671 on branch v5.2.x (Fix numpy 1.25 deprecation warnings)
saimn added a commit that referenced this pull request Apr 25, 2023
…671-on-v5.3.x

Backport PR #14671 on branch v5.3.x (Fix numpy 1.25 deprecation warnings)
pllim added a commit that referenced this pull request Apr 27, 2023
…-on-v5.0.x

Backport PR #14671 on branch v5.0.x (Fix numpy 1.25 deprecation warnings)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_convolve_kernels.py fails with deprecation warning about Conversion of an array with ndim > 0 to a scalar is deprecated

3 participants