Implement late review suggestions on #14421 - #14653

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Oh and I think the situation here is that the EarthLocation.from_geodetic requires #14423 to work, but EarthLocation.from_geocentric is a separate problem. But @mhvk might want to weigh in if you have more insight.

pre-commit.ci autofix

My sense would be to move this to 6.0; I really want to make the structured dtype work anyway, and we might then as well built that on top of this. I don't see much advantage to merging this now.

If you change the milestone, pls remove the Affects-dev label and rethink whether this needs a change log, because it would affect released code. FYI.

I'm 90% of the way with a PR for 6.0 that does structured dtypes (and which includes these commits)... Removed affects-dev...

I'm fine with leaving it to 6.0 !

Ping @eteq since 6.0 is in the works.

Ah, good to be reminded! I did actually return to my branch on allowing structured dtypes in Distribution, and have something that should be fairly close. I'll try to push a PR in the next few days (probably best if I first reorganize it a bit...).

See #15296 for a start of a fix...

See #15304 for what is actually needed to work with EarthLocation. Thankfully, quite minimal changes to EarthLocation itself.

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

Superseded by #15304