Skip to content

TST: Only run some doctest with numpy<1.25 - #14550

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:one-dtype-endian-two-dtype-endian
Mar 17, 2023
Merged

TST: Only run some doctest with numpy<1.25#14550
pllim merged 1 commit into
astropy:mainfrom
pllim:one-dtype-endian-two-dtype-endian

Conversation

@pllim

@pllim pllim commented Mar 17, 2023

Copy link
Copy Markdown
Member

Description

This pull request is to only run some doctest with numpy<1.25 to avoid change in printed dtype caused by numpy/numpy#23295 . We can naturally undo it when we finally bump numpy minversion to 1.25 in the future.

Fixes #14545

@pllim pllim added this to the v5.0.6 milestone Mar 17, 2023
@pllim pllim mentioned this pull request Mar 17, 2023
Closed
@github-actions

github-actions Bot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

github-actions Bot commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
TST: Only run some doctest with numpy<1.25
e22607f 
to avoid change in printed dtype caused by numpy/numpy#23295
@pllim
pllim force-pushed the one-dtype-endian-two-dtype-endian branch from af9c049 to e22607f Compare March 17, 2023 16:08
@pllim
pllim marked this pull request as ready for review March 17, 2023 16:57
@pllim
pllim requested review from mhvk and saimn March 17, 2023 16:58
mhvk
mhvk approved these changes Mar 17, 2023
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Is it worth it raising a issue that for 5.3 or 6.0 we change it around so that the docs reflect the newest numpy rather than the oldest supported one? (Obviously not as long as it is numpy-dev! They might still change it...)

@pllim

pllim commented Mar 17, 2023

Copy link
Copy Markdown
Member Author

Do you know when they plan to release numpy 1.25? That might decide on when we should update the docs.

@mhvk

mhvk commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

they seem to release in June and December, so I guess this is not relevant for 5.3, but will be for 6.0.

@pllim
pllim merged commit eb87d51 into astropy:main Mar 17, 2023
@pllim
pllim deleted the one-dtype-endian-two-dtype-endian branch March 17, 2023 19:36
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 17, 2023
@pllim @meeseeksmachine
Backport PR astropy#14550: TST: Only run some doctest with numpy<1.25
f8a7bc5
This was referenced Mar 17, 2023
Merged
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Mar 17, 2023
@pllim @meeseeksmachine
Backport PR astropy#14550: TST: Only run some doctest with numpy<1.25
587c579
@pllim pllim mentioned this pull request Mar 17, 2023
Closed
@pllim

pllim commented Mar 17, 2023

Copy link
Copy Markdown
Member Author

I opened #14553 as a follow-up issue. Thanks!

pllim added a commit that referenced this pull request Mar 17, 2023
@pllim
Merge pull request #14552 from meeseeksmachine/auto-backport-of-pr-14…
b4f32f9 
…550-on-v5.2.x

Backport PR #14550 on branch v5.2.x (TST: Only run some doctest with numpy<1.25)
pllim added a commit that referenced this pull request Mar 17, 2023
@pllim
Merge pull request #14551 from meeseeksmachine/auto-backport-of-pr-14…
b589b15 
…550-on-v5.0.x

Backport PR #14550 on branch v5.0.x (TST: Only run some doctest with numpy<1.25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes
@saimn saimn Awaiting requested review from saimn

Assignees

No one assigned

Labels

Docs installation io.fits no-changelog-entry-needed testing

Projects

None yet

Milestone

v5.0.6

Development

Successfully merging this pull request may close these issues.

TST: dtype doctest failures in FITS examples

2 participants

@pllim @mhvk