Skip to content

Release: Drop i686 wheels - #14517

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:drop-i686-wheel
Mar 15, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
pllim:drop-i686-wheel

Conversation

@pllim

@pllim pllim commented Mar 10, 2023

Copy link
Copy Markdown
Member

Description

This pull request is to drop building wheels for i686 because numpy no longer does it either.

This hopefully is much less controversial than #14513.

@pllim pllim added Release platform-i386 Build all wheels Run all the wheel builds rather than just a selection labels Mar 10, 2023
@pllim pllim added this to the v5.3 milestone Mar 10, 2023
@pllim
pllim requested review from a team and olebole March 10, 2023 19:00
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Mar 10, 2023
2 tasks
@pllim

pllim commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

numpy dev deprecation warnings are unrelated

@olebole olebole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we don't use wheels for Debian, I have no objections here.

@saimn saimn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on doing this

@pllim
pllim merged commit c0a24c1 into astropy:main Mar 15, 2023
@pllim
pllim deleted the drop-i686-wheel branch March 15, 2023 17:40
@pllim

pllim commented Mar 15, 2023

Copy link
Copy Markdown
Member Author

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build all wheels Run all the wheel builds rather than just a selection installation platform-i386 Release testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants