Skip to content

Catch deprecation warning from asdf.types - #14429

Merged
pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/asdf_types_deprecation
Feb 22, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
WilliamJamieson:bugfix/asdf_types_deprecation

Conversation

@WilliamJamieson

@WilliamJamieson WilliamJamieson commented Feb 22, 2023 •

Copy link
Copy Markdown
Contributor

Description

ASDF has deprecated asdf.types in asdf-format/asdf#1401. This PR catches the deprecation warning in astropy. This si causing CI failures e.g.: https://github.com/astropy/astropy/actions/runs/4243827152/jobs/7377092508

@github-actions

github-actions Bot commented Feb 22, 2023 •

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim added this to the v5.0.6 milestone Feb 22, 2023
@pllim
pllim merged commit f6dab2f into astropy:main Feb 22, 2023
@WilliamJamieson
WilliamJamieson deleted the bugfix/asdf_types_deprecation branch February 22, 2023 16:47
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 22, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 22, 2023
pllim added a commit that referenced this pull request Feb 22, 2023
…429-on-v5.0.x

Backport PR #14429 on branch v5.0.x (Catch deprecation warning from `asdf.types`)
pllim added a commit that referenced this pull request Feb 22, 2023
…429-on-v5.2.x

Backport PR #14429 on branch v5.2.x (Catch deprecation warning from `asdf.types`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants