Skip to content

Allow the use of Distribution in Representations - #14423

Closed
mhvk wants to merge 6 commits into
astropy:mainfrom
mhvk:distribution-representation
Closed

mhvk wants to merge 6 commits into
astropy:mainfrom
mhvk:distribution-representation

Conversation

@mhvk

@mhvk mhvk commented Feb 20, 2023 •

Copy link
Copy Markdown
Contributor

This pull request implements the basics needed to pass in Distribution arrays to representations, and have transformations to other representations work, also in the presence of differentials. Some small changes were required to be made to Quantity and some representations, but arguably those really are bug fixes.

This is not quite done, of course:

  • gufuncs should be fully supported rather than just with a hack (which will break on matmul).
  • numpy function overrides should be more complete. Many will likely just work, but this needs testing

EDIT: EDIT: built on top of #14421. now merged. Also moved the milestone to 6.0 since this remains a draft. Likely should be split in more bite-size pieces; e.g., gufunc (e.g., check with some erfa routines and matmul), __array_function__ (tedious test writing...), and then combining it for Representation and after that Frame and SkyCoord.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@mhvk

mhvk commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

@eteq, @nstarman, @eerovaher - this is where I hope to go (but first steps in #14421).

@mhvk mhvk changed the title Distribution representation Allow the use of Distribution in Representations Feb 21, 2023
@mhvk
mhvk force-pushed the distribution-representation branch from c6410db to 660b170 Compare April 18, 2023 18:31
@mhvk mhvk modified the milestones: v5.3, v6.0 Apr 18, 2023
@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Sep 16, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@mhvk

mhvk commented Sep 27, 2023

Copy link
Copy Markdown
Contributor Author

Closing in favour of #15395, which builds on current main, with all the work for EarthLocation included, and hence is much simpler.

@mhvk mhvk closed this Sep 27, 2023
@mhvk
mhvk deleted the distribution-representation branch September 27, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close? Tell stale bot that this issue/PR is stale coordinates Enhancement uncertainty units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant