Repository navigation
Clean up formatting of units in unicode and console formats - #14413
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
olebole
approved these changes
Feb 18, 2023
| s = "" | ||
| else: | ||
| s = cls.format_exponential_notation(unit.scale) | ||
| s = cls.format_exponential_notation(unit.scale) + " " |
Member
There was a problem hiding this comment.
To be nitpicky here: for a scale-only unit this adds a trailing space:
>>> u.Unit(10).to_string('unicode')
'10 'Probably one again use a "parts" list and " ".join(parts) at the end, as in generic.py (but just with 1-2 parts)?
Contributor
Author
There was a problem hiding this comment.
Good catch! the parts use is a bit tricky given the possible multiple lines so I just added the space only when needed. It turned out for latex the same mistake was made, so I corrected that while I was at it.
mhvk
force-pushed
the
units-format-unicode-console-strings
branch
from
February 18, 2023 15:09
31327b9 to
5f40d64
Compare
Contributor
Author
pllim
approved these changes
Feb 18, 2023
pllim
left a comment
pllim
left a comment
Member
There was a problem hiding this comment.
I am approving by proxy but I will give nstarman a chance to review.
Thanks!
mhvk
pushed a commit
to mhvk/astropy
that referenced
this pull request
Feb 19, 2023
…le-strings Clean up formatting of units in unicode and console formats
This was referenced Feb 19, 2023
davidgegiya
added a commit
to davidgegiya/agent-orchestrator
that referenced
this pull request
Nov 8, 2026
…s include an extraneous space Pin 34d79ea59b3ba25820dfe7fc9782e9014826e8b0 and its regression selectors for reproducible runs. Source: astropy/astropy#14413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is to address that in
consoleandunicodeformat, spaces were not always done properly: for units typeset as a fraction there was a space in front of the unit even without a scale factor, while for units set on a single line, there was no space between the scale factor and the unit.(Plus some small bits of refactoring while I was at it.)
Fixes #14409