Skip to content

Update IERS_B as well as its URL - #14384

Merged
pllim merged 1 commit into
astropy:mainfrom
mhvk:iers-new-iers-b-url
Feb 14, 2023
Merged

Update IERS_B as well as its URL#14384
pllim merged 1 commit into
astropy:mainfrom
mhvk:iers-new-iers-b-url

Conversation

@mhvk

@mhvk mhvk commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Description

This pull request is to address the problem that the IERS_B_URL has changed. Here, it points it to the new location of the "old style" files that we were using. #14382 updates the code to the new style, which probably should only be done for 5.3.

Fixes #14380

@mhvk mhvk added this to the v5.0.6 milestone Feb 14, 2023
@github-actions

github-actions Bot commented Feb 14, 2023 •
edited by pllim
Loading

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

This was referenced Feb 14, 2023
Merged
Closed
@mhvk
mhvk requested a review from pllim February 14, 2023 21:24
@mhvk

mhvk commented Feb 14, 2023

Copy link
Copy Markdown
Contributor Author

OK, this one seems to pass (assuming readthedocs is unrelated, which it seems to be).

@pllim

pllim commented Feb 14, 2023

Copy link
Copy Markdown
Member

Tsk tsk RTD might be because matplotlib released 3.7 yesterday, so probably unrelated, as you said.

pllim
pllim approved these changes Feb 14, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this does look much less disruptive. Let's get this in and figure out the rest in follow-up PR, as you planned. Thank you!

@pllim
pllim merged commit 69b62c6 into astropy:main Feb 14, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 14, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 14, 2023
@pllim @meeseeksmachine
Backport PR astropy#14384: Update IERS_B as well as its URL
c140bc0
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 14, 2023
@pllim @meeseeksmachine
Backport PR astropy#14384: Update IERS_B as well as its URL
b460d72
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 14, 2023
Merged
@mhvk
mhvk deleted the iers-new-iers-b-url branch February 14, 2023 22:01
pllim added a commit that referenced this pull request Feb 14, 2023
@pllim
Merge pull request #14388 from meeseeksmachine/auto-backport-of-pr-14…
f203349 
…384-on-v5.2.x

Backport PR #14384 on branch v5.2.x (Update IERS_B as well as its URL)
pllim added a commit that referenced this pull request Feb 14, 2023
@pllim
Merge pull request #14387 from meeseeksmachine/auto-backport-of-pr-14…
8a44832 
…384-on-v5.0.x

Backport PR #14384 on branch v5.0.x (Update IERS_B as well as its URL)
@pllim pllim mentioned this pull request Feb 15, 2023
Closed
pllim added a commit to pllim/astropy that referenced this pull request Feb 15, 2023
@pllim
Partially revert astropy#14384
b66f7fb 
but keep the IERS table update and switch to HTTPS.
Now this no longer need a change log.
@pllim pllim mentioned this pull request Feb 15, 2023
Merged
dougbrn pushed a commit to dougbrn/astropy that referenced this pull request Mar 13, 2023
@pllim @dougbrn
Partially revert astropy#14384
d4b287f 
but keep the IERS table update and switch to HTTPS.
Now this no longer need a change log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Bug utils.iers utils

Projects

None yet

Milestone

v5.0.6

Development

Successfully merging this pull request may close these issues.

IERS_B file download failure: 404 error

2 participants

@mhvk @pllim