Skip to content

Issue astropy/astropy#14380: Repoint IERS_B url at new naming convention - #14381

Closed
jpl-jengelke wants to merge 2 commits into
astropy:mainfrom
jpl-jengelke:main
Closed

Issue astropy/astropy#14380: Repoint IERS_B url at new naming convention#14381
jpl-jengelke wants to merge 2 commits into
astropy:mainfrom
jpl-jengelke:main

Conversation

@jpl-jengelke

@jpl-jengelke jpl-jengelke commented Feb 14, 2023

Copy link
Copy Markdown

Description

This pull request fixes the file naming and URL changes to the International Earth Rotation and Reference Systems Service (IERS) files referenced in the Astropy IERS package. Note that the file naming changed in this URL: https://hpiers.obspm.fr/iers/eop/eopc04/ . The gist of the change removed _IA2000 from file names. ...

Fixes #14380

@github-actions

github-actions Bot commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

github-actions[bot]
github-actions Bot reviewed Feb 14, 2023
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail [email protected].

@jpl-jengelke
jpl-jengelke marked this pull request as draft February 14, 2023 05:07
@jpl-jengelke jpl-jengelke reopened this Feb 14, 2023
@jpl-jengelke

jpl-jengelke commented Feb 14, 2023

Copy link
Copy Markdown
Author

pre-commit.ci autofix

@jpl-jengelke

jpl-jengelke commented Feb 14, 2023

Copy link
Copy Markdown
Author

This is a light touch fix that replaces the deprecated file with a legacy data file that uses new data but formats according to the old spec. This may be more appropriate as a hotfix for earlier releases.

@jpl-jengelke
jpl-jengelke marked this pull request as ready for review February 14, 2023 18:19
@jpl-jengelke jpl-jengelke changed the title Closes astropy/astropy#14380: Repoint IERS files and urls at new naming convention Issue astropy/astropy#14380: Repoint IERS files and urls at new naming convention Feb 14, 2023
@jpl-jengelke jpl-jengelke changed the title Issue astropy/astropy#14380: Repoint IERS files and urls at new naming convention Issue astropy/astropy#14380: Repoint IERS url at new naming convention Feb 14, 2023
@jpl-jengelke jpl-jengelke changed the title Issue astropy/astropy#14380: Repoint IERS url at new naming convention Issue astropy/astropy#14380: Repoint IERS_B url at new naming convention Feb 14, 2023
@jpl-jengelke jpl-jengelke mentioned this pull request Feb 14, 2023
Closed
@jpl-jengelke
jpl-jengelke marked this pull request as draft February 14, 2023 19:27
@jpl-jengelke

jpl-jengelke commented Feb 14, 2023

Copy link
Copy Markdown
Author

Converted to draft and closing once again. Although the IERS_B data at the legacy dataset URL seemed to pass local pytest tests, it's apparent there is an incongruity between some combination of the IERS_A data file (not cached), the actual data types and/or static test data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

utils.iers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IERS_B file download failure: 404 error

1 participant

@jpl-jengelke