Skip to content

Re-enable PPC cron job - #14310

Merged
pllim merged 1 commit into
astropy:mainfrom
astrofrog:enable-ppc-ci
Jan 24, 2023
Merged

Re-enable PPC cron job#14310
pllim merged 1 commit into
astropy:mainfrom
astrofrog:enable-ppc-ci

Conversation

@astrofrog

@astrofrog astrofrog commented Jan 24, 2023 •
edited by pllim
Loading

Copy link
Copy Markdown
Member

Description

This seems to work in my fork (https://github.com/astrofrog/astropy/actions/runs/3990781909/jobs/6844828799)

If this passes here, then I think it:

I wonder if the failures before were due to e.g. a Numpy bug as we haven't really done anything here to fix those problems.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added this to the v5.3 milestone Jan 24, 2023
pllim
pllim approved these changes Jan 24, 2023
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, no fixes required... 🤯

@pllim
pllim merged commit a73234d into astropy:main Jan 24, 2023
DougBurke added a commit to DougBurke/sherpa that referenced this pull request May 22, 2024
@DougBurke
CI: include ppc64le archicture in weekly arch builds
c84ad08 
AstroPy restored PPC testing in

  astropy/astropy#14310

so let's see if we can.
@DougBurke DougBurke mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

Extra CI Run cron CI as part of PR no-changelog-entry-needed platform-ppc testing

Projects

None yet

Milestone

v5.3

Development

Successfully merging this pull request may close these issues.

test_biweight_32bit_runtime_warnings fails on ppc64le io.fits and Lomb-Scargle test failures on ppc64le test_integer_inputs fails on ppc64le

2 participants

@astrofrog @pllim