Skip to content

DOC: Change back numpy URL for sphinx-gallery - #14288

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:np-devdocs
Jan 20, 2023
Merged

pllim merged 1 commit into
astropy:mainfrom
pllim:np-devdocs

Conversation

@pllim

@pllim pllim commented Jan 20, 2023 •

Copy link
Copy Markdown
Member

Description

https://numpy.org/devdocs/ now gives a 404

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
pllim marked this pull request as ready for review January 20, 2023 23:53
@pllim

pllim commented Jan 20, 2023

Copy link
Copy Markdown
Member Author

RTD green, so merging.

@pllim
pllim merged commit 8dfd151 into astropy:main Jan 20, 2023
@pllim
pllim deleted the np-devdocs branch January 20, 2023 23:57
@lumberbot-app

This comment was marked as resolved.

@lumberbot-app

This comment was marked as resolved.

pllim added a commit that referenced this pull request Jan 21, 2023
pllim added a commit that referenced this pull request Jan 21, 2023
@pllim

pllim commented Jan 21, 2023

Copy link
Copy Markdown
Member Author

Manual backports done directly in branches. FYI.

@mhvk

mhvk commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Yay, thanks @pllim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants