Repository navigation
Backport PR #13651 on branch v5.0.x (MNT: Fix test compat with scipy 1.10.0) - #13654
Merged
pllim merged 1 commit intoSep 13, 2022
Merged
Conversation
dhomeier
reviewed
Sep 12, 2022
Comment on lines
+1142
to
+1147
| if SCIPY_LT_1_10: | ||
| import scipy.misc | ||
| scipy_data = scipy.misc.ascent() | ||
| else: | ||
| import scipy.datasets | ||
| scipy_data = scipy.datasets.ascent() |
Contributor
There was a problem hiding this comment.
Suggested change
| if SCIPY_LT_1_10: | |
| import scipy.misc | |
| scipy_data = scipy.misc.ascent() | |
| else: | |
| import scipy.datasets | |
| scipy_data = scipy.datasets.ascent() | |
| if SCIPY_LT_1_10: | |
| scipy_data = scipy.misc.ascent() | |
| else: | |
| scipy_data = scipy.datasets.ascent() |
Seems both submodules are already imported by default.
Member
There was a problem hiding this comment.
Oh oops... I will merge this and then create a follow-up PR and backport that too. Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #13651: MNT: Fix test compat with scipy 1.10.0