Skip to content

MNT: Fix test compat with scipy 1.10.0 - #13651

Merged
pllim merged 1 commit into
astropy:mainfrom
pllim:scipy-dev-compat
Sep 12, 2022
Merged

MNT: Fix test compat with scipy 1.10.0#13651
pllim merged 1 commit into
astropy:mainfrom
pllim:scipy-dev-compat

Conversation

@pllim

@pllim pllim commented Sep 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This pull request is to address compatibility issue with scipy dev.

Fix #13644

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Do the proposed changes need the code-style fixed?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added this to the v5.0.5 milestone Sep 12, 2022
@github-actions

This comment was marked as resolved.

Sign in to view
@pllim pllim mentioned this pull request Sep 12, 2022
Closed
7 of 11 tasks
@pllim

This comment was marked as resolved.

Sign in to view
@pllim
pllim force-pushed the scipy-dev-compat branch 2 times, most recently from c093208 to 7a098de Compare September 12, 2022 18:47
@pllim
pllim marked this pull request as ready for review September 12, 2022 19:37
@pllim
pllim requested a review from saimn as a code owner September 12, 2022 19:37
Cadair
Cadair reviewed Sep 12, 2022
View reviewed changes
Comment thread astropy/io/fits/tests/test_image.py
import scipy.misc
scipy_data = scipy.misc.ascent()
else:
import scipy.datasets

@Cadair Cadair Sep 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this download data?

@pllim pllim Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think it downloads the "ascent" image data from their repo.

@pllim pllim Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think? https://github.com/scipy/scipy/blob/06da9ee65cdee4a8aa036767489bfc5a030527f4/scipy/datasets/_fetchers.py#L76

Hmm, should we mark this as remote data?

@Cadair Cadair Sep 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should we mark this as remote data?

This was my thinking, but then I am surprised it worked without that.

@pllim pllim Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://raw.githubusercontent.com/scipy/dataset-ascent/main/ascent.dat

@pllim pllim Sep 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cadair , looks better?

@pllim
MNT: Fix test compat with scipy 1.10.0
00e265b 
TST: scipy.datasets needs pooch
@pllim
pllim merged commit 08e09fd into astropy:main Sep 12, 2022
@pllim
pllim deleted the scipy-dev-compat branch September 12, 2022 20:52
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 12, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 12, 2022
@pllim @meeseeksmachine
Backport PR astropy#13651: MNT: Fix test compat with scipy 1.10.0
67d43cd
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 12, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Sep 12, 2022
@pllim @meeseeksmachine
Backport PR astropy#13651: MNT: Fix test compat with scipy 1.10.0
f66d152
pllim added a commit that referenced this pull request Sep 12, 2022
@pllim
Merge pull request #13655 from meeseeksmachine/auto-backport-of-pr-13…
cc3222f 
…651-on-v5.1.x

Backport PR #13651 on branch v5.1.x (MNT: Fix test compat with scipy 1.10.0)
pllim added a commit that referenced this pull request Sep 13, 2022
@pllim
Merge pull request #13654 from meeseeksmachine/auto-backport-of-pr-13…
faae335 
…651-on-v5.0.x

Backport PR #13651 on branch v5.0.x (MNT: Fix test compat with scipy 1.10.0)
@pllim pllim mentioned this pull request Sep 13, 2022
Merged
11 tasks done
@pllim pllim mentioned this pull request Mar 21, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes
@saimn saimn Awaiting requested review from saimn saimn is a code owner

Assignees

No one assigned

Labels

io.fits no-changelog-entry-needed Ready-for-final-review testing

Projects

None yet

Milestone

v5.0.5

Development

Successfully merging this pull request may close these issues.

TST: scipy.misc.ascent has been deprecated in SciPy v1.10.0

2 participants

@pllim @Cadair